fix: ignore the error that directoryPath is not a directory#226
Open
liximomo wants to merge 2 commits intowebpack:mainfrom
Open
fix: ignore the error that directoryPath is not a directory#226liximomo wants to merge 2 commits intowebpack:mainfrom
liximomo wants to merge 2 commits intowebpack:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
===========================================
- Coverage 92.12% 78.11% -14.01%
===========================================
Files 6 6
Lines 1041 1042 +1
Branches 249 250 +1
===========================================
- Hits 959 814 -145
- Misses 82 228 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error is caused by a specific alias config of webpack, considering the following example:
With the above config, we will get a
DirectoryWatcherwatchingsrc/foo/index. If you happen to have asrc/foofile on your filesystem, you will see the error:We could safely ignore the error of
ENOTDIRin whatever cases.Related Issues:
nuxt/bridge#226